[libvirt] [PATCH v3 1/2] util: Functions for getting/setting device options

Michal Privoznik mprivozn at redhat.com
Fri Jan 30 12:23:06 UTC 2015


On 22.01.2015 20:47, akrowiak at linux.vnet.ibm.com wrote:
> From: Tony Krowiak <akrowiak at linux.vnet.ibm.com>
> 
> This patch provides the utility functions needed to synchronize
> the rxfilter changes made to a guest domain with the corresponding
> macvtap devices on the host:
> 
> * Get/set PROMISC flag
> * Get/set ALLMULTI, MULTICAST
> 
> Signed-off-by: Tony Krowiak <akrowiak at linux.vnet.ibm.com>
> ---
> Changes for v3:
> * Fixed a syntax-check error in virNetDevGetRxFilter function
> 
>  src/libvirt_private.syms |    8 ++-
>  src/util/virnetdev.c     |  186 +++++++++++++++++++++++++++++++++++++++-------
>  src/util/virnetdev.h     |   24 ++++++-
>  3 files changed, 190 insertions(+), 28 deletions(-)
> 

> diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
> index ef96b2b..5d330ce 100644
> --- a/src/util/virnetdev.c
> +++ b/src/util/virnetdev.c

> @@ -717,6 +768,70 @@ int virNetDevIsOnline(const char *ifname,
>  
>  
>  /**
> + * virNetDevGetOnline:
> + * @ifname: the interface name
> + * @online: where to store the status
> + *
> + * Function to query if an interface is activated (true) or not (false)
> + *
> + * Returns 0 in case of success or an errno code in case of failure.
> + */
> +int virNetDevGetOnline(const char *ifname,
> +                      bool *online)

Indentation's off.

> +{
> +    return virNetDevGetIFFlag(ifname, IFF_UP, online);
> +}
> +

ACK with that fixed.

Michal




More information about the libvir-list mailing list