[libvirt] [PATCH 0/2] Forbid starting VMs with bandwidth on unsupported vNIC type
Michal Privoznik
mprivozn at redhat.com
Wed Jan 7 17:31:04 UTC 2015
The patch 1/2 is trivial.
The patch 2/2 is controversial and I expect heavy discussion on
it :-) Thing is, there might be somebody misusing our XML to
store the QoS setting, and do the actual setting themselves in
startup hook. Now with this patch, we will forbid such usage
scenario.
Michal Privoznik (2):
conf: Increase virNetDevBandwidthParse intelligence
qemu, lxc: Fail explicitly if setting QoS on unsupported vNIC types
src/conf/domain_conf.c | 10 ++++++----
src/conf/netdev_bandwidth_conf.c | 38 +++++++++++++++++++++++---------------
src/conf/netdev_bandwidth_conf.h | 7 ++++---
src/conf/network_conf.c | 7 +++----
src/lxc/lxc_driver.c | 20 +++++++++++++++-----
src/lxc/lxc_process.c | 20 +++++++++++++++-----
src/qemu/qemu_command.c | 21 +++++++++++++++------
src/qemu/qemu_hotplug.c | 20 +++++++++++++++-----
tests/virnetdevbandwidthtest.c | 12 ++++++------
9 files changed, 102 insertions(+), 53 deletions(-)
--
2.0.5
More information about the libvir-list
mailing list