[libvirt] [PATCH v3] Makefile: Fix parallel build after Xen-xl parser introduction

[Eric Blake]

On 01/07/2015 02:08 PM, Eric Blake wrote:
> On 01/07/2015 10:17 AM, Pavel Hrdina wrote:
>> Well, the parallel build doesn't work as there are not dependencies
>> set correctly. When running 'make -j' I see this error:
>>
>> make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src'
>>   GEN      util/virkeymaps.h
>>   GEN      locking/lock_protocol.h
>> make[2]: *** No rule to make target 'xenconfig/xen_xl_disk.h', needed by 'all'.  Stop.
>> make[2]: *** Waiting for unfinished jobs....
>>   GEN      lxc/lxc_controller_dispatch.h
>>
>> The fix is to correctly set dependencies by letting make know that .c
>> and .h are to be generated from .l. Moreover, the section is moved
>> closer to the other section which uses it.
> 
> Still not working for me in VPATH, and I still haven't figured out why... :)

The error I got this time was:

  CC       xenconfig/libvirt_xenconfig_la-xen_xl.lo
../../src/xenconfig/xen_xl.c:29:25: fatal error: xen_xl_disk.h: No such
file or directory
 #include "xen_xl_disk.h"
                         ^
compilation terminated.
  CC       xenconfig/libvirt_xenxldiskparser_la-xen_xl_disk.lo

but that may be an issue with me starting from a dirty build (make has
the annoying habit of treating a target as up-to-date if the file exists
in srcdir, even if you have rewritten the makefile to generate the file
only into builddir).  I'll try again from a fresh clone.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150107/ab022275/attachment-0001.sig>