[libvirt] [PATCH v2 07/11] parallels: don't override error message when XML parsing fails

[Jiri Denemark]

On Thu, Jan 08, 2015 at 15:48:18 +0000, Daniel Berrange wrote:
> The virDomainDefParseString method will report a suitable error
> on parsing fail, so don't replace that.
> ---
>  src/parallels/parallels_driver.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
> index f83b504..1731259 100644
> --- a/src/parallels/parallels_driver.c
> +++ b/src/parallels/parallels_driver.c
> @@ -670,11 +670,8 @@ parallelsDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int
>      parallelsDriverLock(privconn);
>      if ((def = virDomainDefParseString(xml, privconn->caps, privconn->xmlopt,
>                                         1 << VIR_DOMAIN_VIRT_PARALLELS,
> -                                       VIR_DOMAIN_XML_INACTIVE)) == NULL) {
> -        virReportError(VIR_ERR_INVALID_ARG, "%s",
> -                       _("Can't parse XML desc"));
> +                                       VIR_DOMAIN_XML_INACTIVE)) == NULL)
>          goto cleanup;
> -    }
>  
>      olddom = virDomainObjListFindByUUID(privconn->domains, def->uuid);
>      if (olddom == NULL) {

ACK

Jirka