[libvirt] [PATCH 2/9] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

[Michal Privoznik]

On 08.12.2014 19:31, Matthias Gatto wrote:
> Uniformize backing store usage by calling virStorageSourceGetBackingStore
> instead of setting backing store manually.
>
> Signed-off-by: Matthias Gatto <matthias.gatto at outscale.com>
> ---
>   src/conf/domain_conf.c                |  7 ++++---
>   src/conf/storage_conf.c               |  4 ++--
>   src/qemu/qemu_cgroup.c                |  4 ++--
>   src/qemu/qemu_domain.c                |  2 +-
>   src/qemu/qemu_driver.c                | 12 ++++++------
>   src/security/security_dac.c           |  2 +-
>   src/security/security_selinux.c       |  4 ++--
>   src/security/virt-aa-helper.c         |  2 +-
>   src/storage/storage_backend.c         | 12 ++++++------
>   src/storage/storage_backend_fs.c      |  8 ++++----
>   src/storage/storage_backend_logical.c |  2 +-
>   src/util/virstoragefile.c             | 20 ++++++++++----------
>   tests/virstoragetest.c                | 14 +++++++-------
>   13 files changed, 47 insertions(+), 46 deletions(-)
>

> diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
> index 869bf18..3bd82bb 100644
> --- a/src/security/virt-aa-helper.c
> +++ b/src/security/virt-aa-helper.c
> @@ -941,7 +941,7 @@ get_files(vahControl * ctl)
>           /* XXX - if we knew the qemu user:group here we could send it in
>            *        so that the open could be re-tried as that user:group.
>            */
> -        if (!disk->src->backingStore) {
> +        if (!virStorageSourceGetBackingStore(disk->src)) {

s/disk->src/disk->src, 0/

>               bool probe = ctl->allowDiskFormatProbing;
>               virStorageFileGetMetadata(disk->src, -1, -1, probe, false);
>           }

Michal