[libvirt] [PATCH] qemu: fix fail to start vm with one cell use memdev and another not

Peter Krempa pkrempa at redhat.com
Fri Jan 16 08:48:30 UTC 2015


On Fri, Jan 16, 2015 at 10:12:49 +0800, Luyao Huang wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1182467
> 
> We changed our build numa qemu cmd line way in f309db,
> But qemu cannot accept one cell use memdev and another not,
> so this cause a issue when we start a vm with one cell
> have hugpage or nodemask settings and others not.
> 
> After this patch we will use memdev for all cells if there
> is at least one cell need this.
> 
> Signed-off-by: Luyao Huang <lhuang at redhat.com>
> ---
>  src/qemu/qemu_command.c                            | 88 +++++++++++++---------
>  .../qemuxml2argv-numatune-memnode-no-memory.args   |  3 +-
>  2 files changed, 55 insertions(+), 36 deletions(-)
>

I'm currently refactoring this piece of code and this patch would be
mostly reverted and reworked in the end, thus I'm not going to commit it
and I'll fix the bug in the new code after I'm finished with the
refactors.

Thanks for the patch though.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150116/b252fc20/attachment-0001.sig>


More information about the libvir-list mailing list