[libvirt] [PATCH 0/7] Address some Coverity found issues

Michal Privoznik mprivozn at redhat.com
Thu Jul 2 09:30:29 UTC 2015


On 01.07.2015 16:03, John Ferlan wrote:
>

I'm picking a random Coverity thread to express my latest thoughts on
this. I'm not trying to say the problems I'm raising are necessarily
introduced here in this patch set.

We've seen quite a lot of false positives lately. I'm not familiar with
coverity, but does it have a suppress file, something like valgrind has?
In valrgind, one can enumerate stacktraces that would be reported, but
has been investigated by a developer and therefore are known to be okay.
If coverity would have something like that I think should utilize it.

We've poisoned our code with sa_assert()-s, dummy coverity comments,
etc. If we can keep our code clean, that'd be nice. I guess I'm okay
with having the coverity suppress file in the repo - we have the
valgrind one already.

Oh, and for false positives maybe we should file a bug report against
coverity (if possible).

Michal




More information about the libvir-list mailing list