[libvirt] [libvirt-glib PATCHv4 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

[Christophe Fergeau]

On Wed, Jul 01, 2015 at 09:40:51PM +0100, Zeeshan Ali (Khattak) wrote:
> ---
>  libvirt-gobject/libvirt-gobject-network.c | 54 +++++++++++++++++++++++++++++++
>  libvirt-gobject/libvirt-gobject-network.h |  4 +++
>  libvirt-gobject/libvirt-gobject.sym       |  2 ++
>  3 files changed, 60 insertions(+)
> 
> diff --git a/libvirt-gobject/libvirt-gobject-network.c b/libvirt-gobject/libvirt-gobject-network.c
> index b1b38a0..b29be36 100644
> --- a/libvirt-gobject/libvirt-gobject-network.c
> +++ b/libvirt-gobject/libvirt-gobject-network.c
> @@ -29,6 +29,7 @@
>  #include "libvirt-glib/libvirt-glib.h"
>  #include "libvirt-gobject/libvirt-gobject.h"
>  #include "libvirt-gobject-compat.h"
> +#include "libvirt-gobject/libvirt-gobject-network-dhcp-lease-private.h"
>  
>  #define GVIR_NETWORK_GET_PRIVATE(obj)                         \
>          (G_TYPE_INSTANCE_GET_PRIVATE((obj), GVIR_TYPE_NETWORK, GVirNetworkPrivate))
> @@ -224,3 +225,56 @@ GVirConfigNetwork *gvir_network_get_config(GVirNetwork *network,
>      free(xml);
>      return conf;
>  }
> +
> +/**
> + * gvir_network_get_dhcp_leases:
> + * @network: the network
> + * @mac: (allow-none): The optional ASCII formatted MAC address of an interface
> + * @flags: placeholder for flags, pass 0

"must be 0" rather than "pass 0" ?

> + *
> + * @err: Place-holder for possible errors
> + *
> + * This function fetches leases info of guests in the specified network. If the
> + * optional parameter @mac is specified, the returned list will contain only
> + * lease info about a specific guest interface with @mac. There can be multiple
> + * leases for a single @mac because this API supports DHCPv6 too.
> + *
> + * Returns:  (element-type LibvirtGObject.NetworkDHCPLease) (transfer full): the
> + * list of network leases. Each object in the returned list should be unreffed
> + * with g_object_unref() and the list itself using g_list_free, when no longer
> + * needed.
> + */
> +GList *gvir_network_get_dhcp_leases(GVirNetwork *network,
> +                                    const char* mac,
> +                                    guint flags,
> +                                    GError **err)
> +{
> +    virNetworkDHCPLeasePtr *leases;
> +    GList *ret = NULL;
> +    int num_leases, i;
> +
> +    g_return_val_if_fail(GVIR_IS_NETWORK(network), NULL);
> +    g_return_val_if_fail(err == NULL || *err == NULL, NULL);

I'd add a g_return_val_if_fail(flags != 0, NULL);

ACK.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150706/8cf29a42/attachment-0001.sig>