[libvirt] [PATCH v3 2/3] Add PCI-Express root to ARM virt machine

Peter Krempa pkrempa at redhat.com
Tue Jul 7 07:39:00 UTC 2015


On Mon, Jul 06, 2015 at 15:59:26 +0300, Pavel Fedin wrote:
> Add PCI Express root complex if the corresponding capability is present
> 
> Signed-off-by: Pavel Fedin <p.fedin at samsung.com>
> ---
>  src/qemu/qemu_domain.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index f9bf32c..36f411d 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c

...

> @@ -1030,12 +1030,16 @@ qemuDomainDefPostParse(virDomainDefPtr def,
>          break;
>  
>      case VIR_ARCH_ARMV7L:
> -       addDefaultUSB = false;
> -       addDefaultMemballoon = false;
> -       break;
>      case VIR_ARCH_AARCH64:
>         addDefaultUSB = false;
>         addDefaultMemballoon = false;
> +       if (STREQ(def->os.machine, "virt") ||
> +           STRPREFIX(def->os.machine, "virt-")) {
> +           virQEMUDriverPtr driver = opaque;
> +           virQEMUCapsPtr qemuCaps =
> +               virQEMUCapsCacheLookup(driver->qemuCapsCache, def->emulator);
> +           addPCIeRoot = virQEMUCapsGet(qemuCaps, QEMU_CAPS_ARM_VIRT_PCI);

Is there a way where we would make this configurable? Since the "virt"
machine types use the MMIO bus by default we should make the PCI bus
configurable since not everybody might want to add it actually.

> +       }
>         break;
>  
>      case VIR_ARCH_PPC64:
> -- 
> 1.9.5.msysgit.0

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150707/25f863e8/attachment-0001.sig>


More information about the libvir-list mailing list