[libvirt] [glib] Don't overwrite filesystem type when writing format

Christophe Fergeau cfergeau at redhat.com
Tue Jul 7 16:31:04 UTC 2015


On Tue, Jul 07, 2015 at 06:24:38PM +0200, Cedric Bosdonnat wrote:
> On Tue, 2015-07-07 at 17:31 +0200, Christophe Fergeau wrote:
> > This is unintuitive, but after looking at the code and a quick test, I
> > think _add_child() will create the node if it does not exist, and
> > return
> > the existing node if it already exists. So I think this could become:
> > 
> > +        node =
> > gvir_config_object_add_child(GVIR_CONFIG_OBJECT(filesys), "driver");
> 
> Waooh, indeed, not intuitive at all ;)
> I'll use that one then.

We could try to change the name to something better, but I can't really
think of a good name :(

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150707/38e4836c/attachment-0001.sig>


More information about the libvir-list mailing list