[libvirt] [PATCH v2 01/10] docs: Clarify unprivileged sgio feature for host devices
pkrempa at redhat.com
Wed Jul 8 13:04:52 UTC 2015
On Wed, Jul 08, 2015 at 08:56:52 -0400, John Ferlan wrote:
> I don't mind kernel or hypervisor, although it seems kernel is more
> technically correct. How about "hypervisor and OS" like is described for
> the "shareable" attribute which is related?
> So, how about the following:
> If supported by the hypervisor and OS, the optional <code>sgio</code>
> attribute indicates whether unprivileged SG_IO commands are filtered for
> the disk. Valid settings are "filtered" or "unfiltered", where the
> default is "filtered".
> Additionally, given the rest of the conversation, should the <disk>
> discussion of 'sgio' also be updated similarly? Currently it states:
> Indicates whether the kernel will filter unprivileged
> SG_IO commands for the disk, valid settings are "filtered" or
> "unfiltered". Defaults to "filtered". Similar to <code>rawio</code>,
> <code>sgio</code> is only valid for device 'lun'.
> If supported by the hypervisor and OS, indicates whether unprivileged
> SG_IO commands are filtered for the disk. Valid settings are "filtered"
> or "unfiltered" where the default is "filtered". Only available when the
> <code>device</code> is 'lun'.
Both wordings sound okay to me.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: Digital signature
More information about the libvir-list