[libvirt] [PATCH] qemu: fix no error settings if fail to find a disk match path

lhuang lhuang at redhat.com
Thu Jul 9 06:32:09 UTC 2015


On 07/09/2015 11:49 AM, Luyao Huang wrote:
> When we use get blockjob info to a unexist disk path, we will
> get a error like this:
>
>   # virsh blockjob r7 vdc
>   error: An error occurred, but the cause is unknown
>
> This is because we do not set the error when jump to endjob.
> As virDomainDiskByName won't set the error, we need set them
> in the callers function.

Sorry for forget the bz:

https://bugzilla.redhat.com/show_bug.cgi?id=1241355

> Signed-off-by: Luyao Huang <lhuang at redhat.com>
> ---
>   src/qemu/qemu_driver.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 900740e..f134248 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -16414,8 +16414,11 @@ qemuDomainGetBlockJobInfo(virDomainPtr dom,
>       if (qemuDomainSupportsBlockJobs(vm, NULL) < 0)
>           goto endjob;
>   
> -    if (!(disk = virDomainDiskByName(vm->def, path, true)))
> +    if (!(disk = virDomainDiskByName(vm->def, path, true))) {
> +        virReportError(VIR_ERR_INVALID_ARG,
> +                       _("invalid path %s not assigned to domain"), path);
>           goto endjob;
> +    }
>   
>       qemuDomainObjEnterMonitor(driver, vm);
>       ret = qemuMonitorGetBlockJobInfo(qemuDomainGetMonitor(vm),

Luyao




More information about the libvir-list mailing list