[libvirt] [PATCH] conf: Don't allow duplicated targets regardless of bus

Ján Tomko jtomko at redhat.com
Thu Jul 9 08:43:03 UTC 2015


On Thu, Jun 18, 2015 at 04:12:10PM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1142631
> 
> Commit id 'e0e290552' added a check to determine if the same bus
> had the same target value.  It seems that's not quite good enough
> as the check should check the target name value regardless of bus type.
> 
> Also added a DO_TEST_DIFFERENT to exhibit the issue
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/conf/domain_conf.c                             |  3 +-
>  .../qemuxml2argv-disk-same-targets.xml             | 35 ++++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  3 ++
>  3 files changed, 39 insertions(+), 2 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-same-targets.xml

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150709/2903836b/attachment-0001.sig>


More information about the libvir-list mailing list