[libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

Zeeshan Ali (Khattak) zeeshanak at gnome.org
Thu Jul 9 13:41:45 UTC 2015


On Thu, Jul 9, 2015 at 12:56 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, Jul 09, 2015 at 12:42:23PM +0100, Zeeshan Ali (Khattak) wrote:
>> > Honestly, this is a very weird attitude, rather than trying to
>> > come with hard facts, you prefer having some kind of poll and make an
>> > arbitary uninformed decision.
>>
>> I regret having to resort to some sort of poll as well but this is not
>> a purely objective discussion. I did present arguments but you
>> maintain that I did not. So let's leave at that, shall we?
>
> Unless I missed important things, your arguments boiled down to "one
> year is old enough, we should not care about distros".

It's very hard to discuss if you over-exagerate my opinions to make
them sound bad. I'm did not say we should not care about distros but
rather that 1 year is plenty of care.

> I've asked what
> the impact would be on distros, no answer so far.

The answer was that 1 year of grace time is enough and we shouldn't
need to be bound by release cycles and packaging of individual
distros. Also I pointed out the fact that it does not (in practical
terms) make any sense to only upgrade to latest libvirt-glib but
wanting to stay with an year old libvirt.

> I've asked what the
> impact would be in terms of #ifdef ugliness, no answer so far.

The answer was that magnitude of ugliness is irrelevant. Surely you
know that this is not anything objective. To me a single #ifdef is
ugly enough but seems it's not for you so how do you expect either of
us to convince each other with arguments? If you really need something
more concrete, I see at least 12 #ifdefs needed. Pretty ugly for my
taste at least.

> Quite
> hard to make a decision with so few details ;)

All needed "details" are avaiable and it's only a matter of taste and
amount of care we want to give to distros. Both are subjective
matters.

>> I'll just proceed as Dan tell me to. It's his project in the end.
>
> danpb is away for a while as I understand it, and my feeling is that we
> could resolve this on our own if you were at least trying to give more
> details about the various alternatives.

I don't know many alternatives. It's either bumping the dep or adding
ugly #ifdef based solution.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/




More information about the libvir-list mailing list