[libvirt] [PATCH] qemu: don't use initialized ret in qemuRemoveSharedDevice

Peter Krempa pkrempa at redhat.com
Thu Jul 9 17:28:34 UTC 2015


On Thu, Jul 09, 2015 at 19:22:30 +0200, Guido Günther wrote:
> This fixes
> 
>   CC     qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo
>   qemu/qemu_conf.c: In function 'qemuRemoveSharedDevice':
>   qemu/qemu_conf.c:1384:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> ---
> This is only catched by Debian Wheezy's gcc 4.7.2, Jessies gcc 4.9.2 doesn't
> trap on it.
> 
>  src/qemu/qemu_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Oops. I've missed that in my review. ACK if you didn't push this
already.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150709/fba1ae03/attachment-0001.sig>


More information about the libvir-list mailing list