[libvirt] [PATCH] qemu: don't use initialized ret in qemuRemoveSharedDevice

John Ferlan jferlan at redhat.com
Thu Jul 9 20:05:23 UTC 2015



On 07/09/2015 01:28 PM, Peter Krempa wrote:
> On Thu, Jul 09, 2015 at 19:22:30 +0200, Guido Günther wrote:
>> This fixes
>>
>>   CC     qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo
>>   qemu/qemu_conf.c: In function 'qemuRemoveSharedDevice':
>>   qemu/qemu_conf.c:1384:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>> ---
>> This is only catched by Debian Wheezy's gcc 4.7.2, Jessies gcc 4.9.2 doesn't
>> trap on it.
>>
>>  src/qemu/qemu_conf.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> Oops. I've missed that in my review. ACK if you didn't push this
> already.
> 

Well it was there in the patch that got removed <sigh>

http://www.redhat.com/archives/libvir-list/2015-July/msg00209.html

Sorry about that

John




More information about the libvir-list mailing list