[libvirt] [libvirt-snmp][PATCH] LIBVIRT-MIB: Comply with formatting rules

Michal Privoznik mprivozn at redhat.com
Fri Jul 10 09:21:56 UTC 2015


So, I've came along this web site [1] which tries to validate a MIB
file. So I fed it with LIBVIRT-MIB and found some errors. This commit
fixes them so that the test passes again. This should be no functional
change, rather than some formatting change.

1: http://www.simpleweb.org/ietf/mibs/validate/

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/LIBVIRT-MIB.txt | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/LIBVIRT-MIB.txt b/src/LIBVIRT-MIB.txt
index d83db49..a8195ff 100644
--- a/src/LIBVIRT-MIB.txt
+++ b/src/LIBVIRT-MIB.txt
@@ -6,12 +6,10 @@ LIBVIRT-MIB DEFINITIONS ::= BEGIN
 
 IMPORTS
     MODULE-IDENTITY, OBJECT-TYPE, enterprises, Unsigned32, Gauge32,
-    Counter64
-	FROM SNMPv2-SMI
-    OBJECT-GROUP, MODULE-COMPLIANCE
-        FROM SNMPv2-CONF
-    TEXTUAL-CONVENTION, RowStatus
-	FROM SNMPv2-TC
+    Counter64 FROM SNMPv2-SMI
+    OBJECT-GROUP, MODULE-COMPLIANCE FROM SNMPv2-CONF
+    TEXTUAL-CONVENTION, RowStatus FROM SNMPv2-TC
+    NOTIFICATION-TYPE FROM SNMPv2-SMI
 ;
 
 
@@ -78,7 +76,7 @@ LibvirtGuestEntry ::= SEQUENCE {
 
 libvirtGuestUUID OBJECT-TYPE
     SYNTAX      UUID
-    MAX-ACCESS  not-accessible
+    MAX-ACCESS  accessible-for-notify
     STATUS      current
     DESCRIPTION
 	"The UUID of the virtual guest."
@@ -202,11 +200,11 @@ libvirtGuestGroup OBJECT-GROUP
     ::= { libvirtGroups 1 }
 
 libvirtGuestNotif NOTIFICATION-TYPE
-    STATUS current
     OBJECTS { libvirtGuestName,
               libvirtGuestUUID,
               libvirtGuestState,
               libvirtGuestRowStatus }
+    STATUS current
     DESCRIPTION
         "Guest lifecycle notification."
     ::= { libvirtNotifications 1 }
-- 
2.3.6




More information about the libvir-list mailing list