[libvirt] [PATCH] spec: Fix polkit dep on F23

Daniel P. Berrange berrange at redhat.com
Fri Jul 17 14:15:34 UTC 2015


On Tue, Jul 14, 2015 at 02:44:59PM -0400, Cole Robinson wrote:
> As of fedora polkit-0.113-2, polkit-devel only pulls in polkit-libs, not
> full polkit, but we need the latter for pkcheck otherwise our configure
> test fails.
> ---
>  libvirt.spec.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 0adf55e..40d2ccb 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -531,6 +531,8 @@ BuildRequires: cyrus-sasl-devel
>  %endif
>  %if %{with_polkit}
>      %if 0%{?fedora} >= 20 || 0%{?rhel} >= 7
> +# F22 polkit-devel doesn't pull in polkit anymore, which we need for pkcheck
> +BuildRequires: polkit >= 0.112
>  BuildRequires: polkit-devel >= 0.112
>      %else
>          %if 0%{?fedora} || 0%{?rhel} >= 6

NACK.

We don't actually use pkcheck anymore, since we switched to using
dbus API calls. So we should kill the binary check in configure.ac
instead.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list