[libvirt] [PATCH v2 01/12] conf: Remove extraneous check in virDomainHostdevAssignAddress

John Ferlan jferlan at redhat.com
Wed Jul 22 14:54:23 UTC 2015


Since the only way virDomainHostdevAssignAddress can be called is from
within virDomainHostdevDefParseXML when hostdev->source.subsys.type is
VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI, thus there's no need for redundancy.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/conf/domain_conf.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 73ac537..f7bc540 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -5310,9 +5310,6 @@ virDomainHostdevAssignAddress(virDomainXMLOptionPtr xmlopt,
     size_t i;
     int ret;
 
-    if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI)
-        return -1;
-
     for (i = 0; i < def->ncontrollers; i++) {
         if (def->controllers[i]->type != VIR_DOMAIN_CONTROLLER_TYPE_SCSI)
             continue;
-- 
2.1.0




More information about the libvir-list mailing list