[libvirt] Bump tar format?

Daniel P. Berrange berrange at redhat.com
Wed Jul 22 14:58:30 UTC 2015


On Wed, Jul 22, 2015 at 04:44:56PM +0200, Andrea Bolognani wrote:
> Hi everyone,
> 
> commit cc3d52e[1] has apparently broken 'make dist' for at least some
> platforms: Fedora 20 is fine[2], but both Fedora 21 and rawhide[3][4]
> are currently failing. My laptop is running Fedora 22 and can make
> dist just fine, which is of course very confusing.
> 
> The issue is caused by the following tar error:
> 
>   tar: libvirt-1.2.18/tests/nodeinfodata/linux-deconfigured-cpus/     \
>        node/node0/cpu16/topology/core_siblings_list:                  \
>   link name is too long; not dumped
> 
> There seem to be basically two ways to solve the failure:
> 
>   1. rename the test case, making it shorter;
> 
>   2. bump tar format from ustar, which has limitations on the length
>      of file names, to posix/pax, which has no such limitations.
> 
> I'm not a fan of the former option because short names are usually very
> opaque, see tests/nodeinfodata/linux-test[0-8] for some perfect
> examples.
> 
> On the other hand, I'm not sure whether bumping the tar version would
> affect portability in a significant way: the automake documentation[5]
> reports that
> 
>   this format is very young and should probably be restricted to
>   packages that target only very modern platforms
> 
> but the GNU tar documentation[6], while containing some warnings as
> well, suggest that this format is going to become the default.
> 
> Any suggestions on how to proceed?

We've hit this many times before and always just shorten the file
names in GIT to avoid it.

Really we could do with adding a check for filename length to
make check to avoid this again.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list