[libvirt] [PATCHv2 10/17] conf: new pci controller model "pcie-root-port"

John Ferlan jferlan at redhat.com
Thu Jul 23 14:40:26 UTC 2015



On 07/17/2015 02:43 PM, Laine Stump wrote:

missed on first pass

>    <devices>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 1b1f592..0efa0f0 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1739,6 +1739,8 @@
>                      <value>pci-bridge</value>
>                      <!-- implementations of 'dmi-to-pci-bridge' -->
>                      <value>i82801b11-bridge</value>
> +                    <!-- implementations of 'pcie-root-port' -->
> +                    <value>ioh3420</value>
>                    </choice>
>                  </attribute>
>                <empty/>
> @@ -1751,7 +1753,17 @@
>                      <ref name='uint8range'/>
>                    </attribute>
>                  </optional>
> -                <empty/>
> +                <optional>
> +                  <attribute name="chassis">
> +                    <ref name='uint8range'/>
> +                  </attribute>
> +                </optional>
> +                <optional>
> +                  <attribute name="port">
> +                    <ref name='uint8range'/>
> +                  </attribute>
> +                </optional>
> +              <empty/>

This <empty/> seems to be off a space - should it line up under optional
and not element?

John
>                </element>
>              </optional>
>              <!-- *-root controllers have an optional element "pcihole64"-->
> @@ -1774,6 +1786,7 @@
>                    <choice>
>                      <value>pci-bridge</value>
>                      <value>dmi-to-pci-bridge</value>
> +                    <value>pcie-root-port</value>
>                    </choice>
>                  </attribute>
>                </group>




More information about the libvir-list mailing list