[libvirt] [sandbox PATCH 05/11] Image: Refactor create function

Eren Yagdiran erenyagdiran at gmail.com
Thu Jul 23 15:57:31 UTC 2015


Move the docker-related code to the DockerSource and use
the Source mechanism
---
 virt-sandbox-image/sources/DockerSource.py | 95 ++++++++++++++++++++++++++++++
 virt-sandbox-image/sources/Source.py       |  5 ++
 virt-sandbox-image/virt-sandbox-image.py   | 72 +++++-----------------
 3 files changed, 115 insertions(+), 57 deletions(-)

diff --git a/virt-sandbox-image/sources/DockerSource.py b/virt-sandbox-image/sources/DockerSource.py
index 5bcd613..f33f94b 100644
--- a/virt-sandbox-image/sources/DockerSource.py
+++ b/virt-sandbox-image/sources/DockerSource.py
@@ -185,6 +185,101 @@ class DockerSource(Source):
             debug("FAIL %s\n" % str(e))
             raise
 
+    def create_template(self,**args):
+        name = args['name']
+        driver = args['driver']
+        path = args['imagepath'] 
+        path = path if path is not None else self.default_image_path
+        format = args['format'] 
+        format = format if format is not None else self.default_disk_format
+
+        self.__create_template(name,
+                               driver,
+                               path,
+                               format,
+                               path)
+
+    def __create_template(self,name,driver,image_path,format,destdir):
+        self.__check_disk_format(format)
+        
+        imagelist = self.__get_image_list(name,destdir)
+        imagelist.reverse()
+
+        parentImage = None
+        for imagetagid in imagelist:
+            templateImage = destdir + "/" + imagetagid + "/template." + format
+            cmd = ["qemu-img","create","-f","qcow2"]
+            if parentImage is not None:
+                cmd.append("-o")
+                cmd.append("backing_fmt=qcow2,backing_file=%s" % parentImage)
+            cmd.append(templateImage)
+            if parentImage is None:
+                cmd.append("10G")
+            subprocess.call(cmd)
+
+            if parentImage is None:
+                self.__format_disk(templateImage,format,driver)
+
+            self.__extract_tarballs(destdir + "/" + imagetagid + "/template.",format,driver)
+            parentImage = templateImage
+
+
+    def __check_disk_format(self,format):
+        supportedFormats = ['qcow2']
+        if not format in supportedFormats:
+            raise ValueError(["Unsupported image format %s" % format])
+
+    def __get_image_list(self,name,destdir):
+        imageparent = {}
+        imagenames = {}
+        imagedirs = os.listdir(destdir)
+        for imagetagid in imagedirs:
+            indexfile = destdir + "/" + imagetagid + "/index.json"
+            if os.path.exists(indexfile):
+                with open(indexfile,"r") as f:
+                    index = json.load(f)
+                imagenames[index["name"]] = imagetagid
+            jsonfile = destdir + "/" + imagetagid + "/template.json"
+            if os.path.exists(jsonfile):
+                with open(jsonfile,"r") as f:
+                    template = json.load(f)
+                parent = template.get("parent",None)
+                if parent:
+                    imageparent[imagetagid] = parent
+        if not name in imagenames:
+            raise ValueError(["Image %s does not exist locally" %name])
+        imagetagid = imagenames[name]
+        imagelist = []
+        while imagetagid != None:
+            imagelist.append(imagetagid)
+            parent = imageparent.get(imagetagid,None)
+            imagetagid = parent
+        return imagelist
+
+    def __format_disk(self,disk,format,driver):
+        cmd = ['virt-sandbox',
+               '-c',driver,
+               '--disk=file:disk_image=%s,format=%s' %(disk,format),
+               '/sbin/mkfs.ext3',
+               '/dev/disk/by-tag/disk_image']
+        subprocess.call(cmd)
+
+    def __extract_tarballs(self,directory,format,driver):
+        tempdir = "/mnt"
+        tarfile = directory + "tar.gz"
+        diskfile = directory + "qcow2"
+        cmd = ['virt-sandbox',
+               '-c',driver,
+               '-m',
+               'host-image:/mnt=%s,format=%s' %(diskfile,format),
+               '--',
+               '/bin/tar',
+               'zxvf',
+               '%s' %tarfile,
+               '-C',
+               '/mnt']
+        subprocess.call(cmd)
+
 def debug(msg):
     sys.stderr.write(msg)
 
diff --git a/virt-sandbox-image/sources/Source.py b/virt-sandbox-image/sources/Source.py
index 99f44bb..89db14a 100644
--- a/virt-sandbox-image/sources/Source.py
+++ b/virt-sandbox-image/sources/Source.py
@@ -11,3 +11,8 @@ class Source():
     def download_template(self,**args):
         pass
 
+    @abstractmethod
+    def create_template(self,**args):
+      pass
+
+
diff --git a/virt-sandbox-image/virt-sandbox-image.py b/virt-sandbox-image/virt-sandbox-image.py
index 1392e8f..58055b3 100644
--- a/virt-sandbox-image/virt-sandbox-image.py
+++ b/virt-sandbox-image/virt-sandbox-image.py
@@ -132,60 +132,6 @@ def delete_template(name, destdir):
                 parent = None
         imagetagid = parent
 
-
-def get_image_list(name, destdir):
-    imageparent = {}
-    imagenames = {}
-    imagedirs = os.listdir(destdir)
-    for imagetagid in imagedirs:
-        indexfile = destdir + "/" + imagetagid + "/index.json"
-        if os.path.exists(indexfile):
-            with open(indexfile, "r") as f:
-                index = json.load(f)
-            imagenames[index["name"]] = imagetagid
-        jsonfile = destdir + "/" + imagetagid + "/template.json"
-        if os.path.exists(jsonfile):
-            with open(jsonfile, "r") as f:
-                template = json.load(f)
-
-            parent = template.get("parent", None)
-            if parent:
-                imageparent[imagetagid] = parent
-
-    if not name in imagenames:
-        raise ValueError(["Image %s does not exist locally" % name])
-
-    imagetagid = imagenames[name]
-    imagelist = []
-    while imagetagid != None:
-        imagelist.append(imagetagid)
-        parent = imageparent.get(imagetagid, None)
-        imagetagid = parent
-
-    return imagelist
-
-def create_template(name, imagepath, format, destdir):
-    if not format in ["qcow2"]:
-        raise ValueError(["Unsupported image format %s" % format])
-
-    imagelist = get_image_list(name, destdir)
-    imagelist.reverse()
-
-    parentImage = None
-    for imagetagid in imagelist:
-        templateImage = destdir + "/" + imagetagid + "/template." + format
-        cmd = ["qemu-img", "create", "-f", "qcow2"]
-        if parentImage is not None:
-            cmd.append("-o")
-            cmd.append("backing_fmt=qcow2,backing_file=%s" % parentImage)
-        cmd.append(templateImage)
-        if parentImage is None:
-            cmd.append("10G")
-        debug("Run %s\n" % " ".join(cmd))
-        subprocess.call(cmd)
-        parentImage = templateImage
-        
-
 def download(args):
     try:
         dynamic_source_loader(args.source).download_template(name=args.name,
@@ -203,8 +149,13 @@ def delete(args):
     delete_template(args.name, default_template_dir)
 
 def create(args):
-    info("Creating %s from %s in format %s\n" % (args.imagepath, args.name, args.format))
-    create_template(args.name, args.imagepath, args.format, default_template_dir)
+    try:
+        dynamic_source_loader(args.source).create_template(name=args.name,
+                                                           driver=args.driver,
+                                                           imagepath=args.imagepath,
+                                                           format=args.format)
+    except Exception,e:
+        print "Create Error %s" % str(e)
 
 def requires_name(parser):
     parser.add_argument("name",
@@ -215,6 +166,11 @@ def requires_source(parser):
                         default="docker",
                         help=_("name of the template"))
 
+def requires_driver(parser):
+    parser.add_argument("-d","--driver",
+                        default="qemu:///session",
+                        help=_("Type of the driver"))
+
 def requires_auth_conn(parser):
     parser.add_argument("-r","--registry",
                         help=_("Url of the custom registry"))
@@ -243,10 +199,12 @@ def gen_create_args(subparser):
     parser = subparser.add_parser("create",
                                    help=_("Create image from template data"))
     requires_name(parser)
+    requires_source(parser)
+    requires_driver(parser)
     parser.add_argument("imagepath",
                         help=_("path for image"))
     parser.add_argument("format",
-                        help=_("format"))
+                        help=_("format format for image"))
     parser.set_defaults(func=create)
 
 if __name__ == '__main__':
-- 
2.1.0




More information about the libvir-list mailing list