[libvirt] [PATCH] qxl: return 16M instead of 64M in virDomainVideoDefaultRAM

Martin Kletzander mkletzan at redhat.com
Mon Jul 27 05:34:02 UTC 2015


On Mon, Jul 27, 2015 at 12:48:50PM +0800, Lin Ma wrote:
>Return 16M for qxl because QEMU uses 16MB as the default video ram size
>for qxl device since pc-1.2.
>

NACK, that function is not meant to return the default video ram size
of QEMU, but rather video ram size that libvirt will set by default.

>Signed-off-by: Lin Ma <lma at suse.com>
>---
> src/conf/domain_conf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index 6b557d1..8efc973 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -11651,8 +11651,10 @@ virDomainVideoDefaultRAM(const virDomainDef *def,
>         return 4 * 1024;
>
>     case VIR_DOMAIN_VIDEO_TYPE_QXL:
>-        /* QEMU use 64M as the minimal video memory for qxl device */
>-        return 64 * 1024;
>+        /* By default, QEMU uses 16MB as video memory size
>+         * for qxl device since pc-1.2
>+         */
>+        return 16 * 1024;
>
>     default:
>         return 0;
>--
>2.1.4
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150727/dadff7e4/attachment-0001.sig>


More information about the libvir-list mailing list