[libvirt] [PATCH] qemu: Check for iotune_max support properly

Ján Tomko jtomko at redhat.com
Mon Jul 27 07:23:17 UTC 2015


On Mon, Jul 27, 2015 at 08:30:16AM +0200, Martin Kletzander wrote:
> Commit d506a51aeb2a7a7b0c963f760e32b94376ea7173 meant to check for
> QEMU_CAPS_DRIVE_IOTUNE_MAX, but checked for QEMU_CAPS_DRIVE_IOTUNE
> instead.  That's clearly visible from the diff, but it got in.  Because
> of that, we were supplying information unknown for QEMU if it wasn't new
> enough and we couldn't even properly handle the error, leading to
> "Unexpected error".  Also iops_size came at the same time with all the
> other "_max" options, so check whether we're not setting that either if
> QEMU_CAPS_DRIVE_IOTUNE_MAX is not supported.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1224053
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150727/b12fa48f/attachment-0001.sig>


More information about the libvir-list mailing list