[libvirt] [PATCH] docs: set more permissive patterns for paths in rng schemas

John Ferlan jferlan at redhat.com
Mon Jul 27 14:13:29 UTC 2015



On 07/02/2015 11:39 AM, Dmitry Guryanov wrote:
> There is no obvious reason to limit paths, used in
> libvirt to a subset of what is allowed in linux. So
> let's allow any symbols in paths.
> ---
>  docs/schemas/basictypes.rng | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Another seemingly lost patch - based on Dan's response:

http://www.redhat.com/archives/libvir-list/2015-July/msg00060.html

I'm inclined to ACK; however, before pushing I figure by bumping will
give anyone else paying attention this week to provide a contrary opinion.

John
> diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng
> index a83063a..12cab6a 100644
> --- a/docs/schemas/basictypes.rng
> +++ b/docs/schemas/basictypes.rng
> @@ -230,25 +230,25 @@
>  
>    <define name="filePath">
>      <data type="string">
> -      <param name="pattern">[a-zA-Z0-9_\.\+\-\\&"'<>/%]+</param>
> +      <param name="pattern">.+</param>
>      </data>
>    </define>
>  
>    <define name="dirPath">
>      <data type="string">
> -      <param name="pattern">[a-zA-Z0-9_\.\+\-\\&"'<>/%]+</param>
> +      <param name="pattern">.+</param>
>      </data>
>    </define>
>  
>    <define name="absFilePath">
>      <data type="string">
> -      <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%,:]+</param>
> +      <param name="pattern">/.+</param>
>      </data>
>    </define>
>  
>    <define name="absDirPath">
>      <data type="string">
> -      <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%]*</param>
> +      <param name="pattern">/.*</param>
>      </data>
>    </define>
>  
> 




More information about the libvir-list mailing list