[libvirt] [PATCH v2 2/3] Avoid starting a PowerPC VM with floppy disk

Kothapally Madhu Pavan kmp at linux.vnet.ibm.com
Thu Jul 30 11:55:36 UTC 2015


PowerPC pseries based VMs do not support a floppy disk controller.
This prohibits libvirt from creating qemu command with floppy device.

Signed-off-by: Kothapally Madhu Pavan <kmp at linux.vnet.ibm.com>
---
 src/qemu/qemu_command.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 09f30c4..501c7df 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -9767,6 +9767,14 @@ qemuBuildCommandLine(virConnectPtr conn,
                 continue;
             }
 
+            /* PowerPC pseries based VMs do not support floppy device */
+            if ((disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) &&
+                ARCH_IS_PPC64(def->os.arch) && STRPREFIX(def->os.machine, "pseries")) {
+                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                               _("PowerPC pseries machines do not support floppy device"));
+                goto error;
+            }
+
             switch (disk->device) {
             case VIR_DOMAIN_DISK_DEVICE_CDROM:
                 bootindex = bootCD;




More information about the libvir-list mailing list