[libvirt] [PATCH] qemu: Do not reset labels when migration fails

Jiri Denemark jdenemar at redhat.com
Fri Jul 31 12:57:06 UTC 2015


On Fri, Jul 31, 2015 at 14:39:13 +0200, Peter Krempa wrote:
> On Fri, Jul 31, 2015 at 13:57:29 +0200, Jiri Denemark wrote:
> > When stopping a domain on the destination host after a failed migration,
> > we need to avoid reseting security labels since the domain is still
> > running on the source host. While we were correctly doing so in some
> > cases, there were still some paths which did this wrong.
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1242904
> > 
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> >  src/qemu/qemu_driver.c    |  5 ++++-
> >  src/qemu/qemu_migration.c |  3 ++-
> >  src/qemu/qemu_process.c   | 14 ++++++++++----
> >  3 files changed, 16 insertions(+), 6 deletions(-)
> > 
> 
> You also need to fix the case where an incomming migration is killed on
> daemon restart in qemuProcessReconnect.

Yeah, I had that in mind in one moment but I failed to fix this in the
end... v2 coming in a few moments.

Jirka




More information about the libvir-list mailing list