[libvirt] [PATCH 2/2] qemu: Audit memory size with memory hotplug operations

Peter Krempa pkrempa at redhat.com
Wed Jul 1 08:25:09 UTC 2015


On Tue, Jun 30, 2015 at 18:03:29 +0200, Martin Kletzander wrote:
> On Fri, Jun 26, 2015 at 05:16:48PM +0200, Peter Krempa wrote:
> >The memory device hot(un)plug was missing calls to the auditing code.
> >
> >Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1226234
> >---
> > src/qemu/qemu_hotplug.c | 20 ++++++++++++++------
> > 1 file changed, 14 insertions(+), 6 deletions(-)
> >
> >+ cleanup:
> >+    virDomainAuditMemory(vm, oldmem, virDomainDefGetMemoryActual(vm->def),
> >+                         "hotunplug", ret == 0);
> >
> 
> Similarly here.
> 
> You're combining two changes together, but it's fine in this case.
> ACK both patches, safe for freeze.

I changed the string to "update" as suggested and pushed the patch.

Thanks.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150701/a68b518d/attachment-0001.sig>


More information about the libvir-list mailing list