[libvirt] [libvirt-glib] gobject: Remove redundant virtual functions

Zeeshan Ali (Khattak) zeeshanak at gnome.org
Fri Jul 3 15:43:15 UTC 2015


On Fri, Jul 3, 2015 at 3:35 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> On Fri, Jul 03, 2015 at 03:17:42PM +0100, Zeeshan Ali (Khattak) wrote:
>> These virtual functions were most likely a result of copy&paste error.
>> ---
>>  libvirt-gobject/libvirt-gobject-network.h | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/libvirt-gobject/libvirt-gobject-network.h b/libvirt-gobject/libvirt-gobject-network.h
>> index 5617ed6..8c31af4 100644
>> --- a/libvirt-gobject/libvirt-gobject-network.h
>> +++ b/libvirt-gobject/libvirt-gobject-network.h
>> @@ -55,10 +55,7 @@ struct _GVirNetworkClass
>>  {
>>      GObjectClass parent_class;
>>
>> -    void (*started)(GVirNetwork *net);
>> -    void (*stopped)(GVirNetwork *net);
>> -
>> -    gpointer padding[20];
>> +    gpointer padding[22];
>>  };
>
> Although you maintained the struct size ABI, this is still technically
> an API incompatible change / break.
>
> FWIW this is equivalent the the same named slots in the domain class,
> where they are used for signals. It seems we never wired up the signals
> in the network class though, hence why they may appear uneccessary. So
> I think we shouldn't remove them, but instead add the use by signals
> as we have for other classes

Ah they do apply to network as well. Didn't realize that. BTW, virtual
functions are no longer needed/recommended for signals.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/




More information about the libvir-list mailing list