[libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

Christophe Fergeau cfergeau at redhat.com
Wed Jul 8 10:11:18 UTC 2015

On Tue, Jul 07, 2015 at 05:27:39PM +0100, Zeeshan Ali (Khattak) wrote:
> Hi all,
> Christophe pointed out that this and the previous patch binds API that
> was added an year ago:
> commit:  03e0e79e07622496522609741734c2fdcacb5bf2
> Author: Nehal J Wani <nehaljw.kkd1 at gmail.com>
> Date:   Tue Jun 24 02:31:49 2014 +0530
>     net-dhcp-leases: Implement the public APIs
>     Introduce 3 new APIs, virNetworkGetDHCPLeases, virNetworkGetDHCPLeasesForMAC
>     and virNetworkDHCPLeaseFree.
> ---------------
> While I think 1 year old is pretty old enough to justify bumping the
> dep to that version, Christophe thinks its still too soon. I'd hate to
> go through the trouble of adding ugly #ifdef around these new API but
> if others (I guess mainly Dan?) agree with Christophe, I can do that.

1 year being old/not old is not a very useful/convincing argument. What
is more interesting is what (supported) distros are shipping (f21, el7,
oldest ubuntu LTS shipping libvirt-glib, debian, ...).
I'd tend to favour #ifdefs though unless this gets very invasive/ugly ;)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150708/2b1353e8/attachment-0001.sig>

More information about the libvir-list mailing list