[libvirt] [PATCH v3 0/4] Followup for unpriv_sgio changes

John Ferlan jferlan at redhat.com
Wed Jul 8 19:30:24 UTC 2015


I pushed the first 3 patches already since they were ACK'd

This is patches 4-8 adjusted for code review comments

Patch1 (former patch4) - change the function to use qemuCheckUnprivSGIO
    not qemuCheckUnprivSGIO.  Also used a -1 or -2 return value for
    handling the mismatched sgio setting error which requires the caller
    to have a message including the device with the issue

Former patch 5 abandoned

Patch2 (former patch6) - completely removed qemuGetSharedHostdevKey and
    replaced with inline code. Although this looks odd now, a future patch
    will use the device name on the add side.

Patch3 (former patch7) - restored the {} in the right place

Patch4 (former patch8) - remove val initialization - already ACK'd, but
    easier for me to just keep in the current order.

Former patches 9 & 10 - keeping separate for downstream

John Ferlan (4):
  qemu: Refactor qemuCheckSharedDisk to create qemuCheckUnprivSGIO
  qemu: Inline qemuGetHostdevPath
  qemu: Refactor qemuSetUnprivSGIO return values
  qemu: Fix integer/boolean logic in qemuSetUnprivSGIO

 src/qemu/qemu_conf.c | 151 ++++++++++++++++++++++++++++++---------------------
 1 file changed, 89 insertions(+), 62 deletions(-)


More information about the libvir-list mailing list