[libvirt] [PATCH] qemu: Check duplicate WWNs also for hotplugged disks

Martin Kletzander mkletzan at redhat.com
Fri Jul 10 06:29:18 UTC 2015

On Thu, Jul 09, 2015 at 07:56:33PM +0200, Peter Krempa wrote:
>In commit 714b38cb232bcbbd7487af4c058fa6d0999b3326 I tried to avoid
>having two disks with the same WWN in a VM. I forgot to check the
>hotplug paths though which make it possible bypass that check. Reinforce
>the fix by checking the wwn when attaching the disk.
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1208009
> src/conf/domain_conf.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index 1f7862b..5a9a88d 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -22135,6 +22135,34 @@ virDomainDeviceInfoCheckBootIndex(virDomainDefPtr def ATTRIBUTE_UNUSED,
>     return 0;
> }

We should reach some consensus with spacing between functions because
every second patch is changing it.  Not your fault, though, just a
random rant.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150710/dc561f94/attachment-0001.sig>

More information about the libvir-list mailing list