[libvirt] [PATCH] qemuDomainSetNumaParamsLive:

Martin Kletzander mkletzan at redhat.com
Tue Jul 14 08:11:26 UTC 2015

On Mon, Jul 13, 2015 at 06:16:25PM +0200, Michal Privoznik wrote:
>In one of my previous ptaches (bcd9a564) I've tried to fix the problem
>that we blindly assumed strict NUMA mode for guests. This led to
>several problems like us pinning a domain onto a nodeset via libnuma
>among with CGroups. Once the nodeset was changed by user, well, it did
>not result in desired effect. See the original commit for more info.
>But, the commit I wrote had a bug: when NUMA parameters are changed on
>a running domain we require domain to be strictly pinned onto a
>nodeset. Due to a typo a condition was mis-evaluated.
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

You could've just said that we don't allow setting live numa
parameters if there is no numatune/memory in the domain XML,
even though we want to allow that.



>diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>index c8cbd57..8c705c4 100644
>--- a/src/qemu/qemu_driver.c
>+++ b/src/qemu/qemu_driver.c
>@@ -9954,7 +9954,7 @@ qemuDomainSetNumaParamsLive(virDomainObjPtr vm,
>     size_t i = 0;
>     int ret = -1;
>-    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mode) < 0 ||
>+    if (virDomainNumatuneGetMode(vm->def->numa, -1, &mode) == 0 &&
>         virReportError(VIR_ERR_OPERATION_INVALID, "%s",
>                        _("change of nodeset for running domain "
>libvir-list mailing list
>libvir-list at redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150714/4d7d33fc/attachment-0001.sig>

More information about the libvir-list mailing list