[libvirt] [PATCH] configure: clarify rationale for checking pkcheck

Eric Blake eblake at redhat.com
Tue Jul 21 22:30:33 UTC 2015


On 07/21/2015 10:53 AM, Daniel P. Berrange wrote:
> We don't need pkcheck binary, but we must detect it in order
> to see if we're preferring polkit-1 over polkit-0 when both
> are installed. We should also check $with_dbus to see if we
> have dbus-devel available, as that's required to talk to
> polkit-1.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  configure.ac | 27 ++++++++++++++++++++-------
>  1 file changed, 20 insertions(+), 7 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 70b3ef3..db0ccd1 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1339,15 +1339,28 @@ AC_ARG_WITH([polkit],
>  with_polkit0=no
>  with_polkit1=no
>  if test "x$with_polkit" = "xyes" || test "x$with_polkit" = "xcheck"; then
> -  dnl Check for new polkit first - just a binary
> +  dnl Check for new polkit first. We directly talk over DBus
> +  dnl but we use existance of pkcheck binary as a sign that

s/existance/existence/

ACK with that fix.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150721/e344749c/attachment-0001.sig>


More information about the libvir-list mailing list