[libvirt] [PATCH v3 0/9] Selective block device migration implementation

[Kashyap Chamarthy]

On Tue, May 26, 2015 at 03:01:42PM +0200, Michal Privoznik wrote:
> I've taken Pavel's patches, reworked them a bit, added something and sending
> v3. The original patches can be found here:
> 
> https://www.redhat.com/archives/libvir-list/2015-May/msg00697.html
> 
> Michal Privoznik (3):
>   virDomainDiskGetSource: Mark passed disk as 'const'
>   qemuMigrationBeginPhase: Fix function header indentation
>   qemuMigrationDriveMirror: Pass disk format to qemu
> 
> Pavel Boldin (6):
>   util: multi-value virTypedParameter
>   util: multi-value parameters in virTypedParamsAdd*
>   util: virTypedParams{Filter,PickStrings}
>   util: add virTypedParamsAddStringList
>   qemu: migration: selective block device migration
>   virsh: selective block device migration

I've just applied this series on current git master:

    $ git describe
    v1.2.16-17-ga98cb8d

    $ git log --oneline | head -9
    a98cb8d virsh: selective block device migration
    f57141e qemu: migration: selective block device migration
    2757805 util: add virTypedParamsAddStringList
    9b4e1be util: virTypedParams{Filter,PickStrings}
    4385cf0 util: multi-value parameters in virTypedParamsAdd*
    f83965b util: multi-value virTypedParameter
    89d6ddf qemuMigrationDriveMirror: Pass disk format to qemu
    dd81938 qemuMigrationBeginPhase: Fix function header indentation
    c98a95a virDomainDiskGetSource: Mark passed disk as 'const'

And, `make` seems to fail here:

    $ ~/tinker-space/libvirt/./autogen.sh --system
    $ make -j4
    [. . .]
    /home/kashyapc/tinker-space/libvirt/./src/qemu/qemu_migration.c: In function 'qemuMigrationRun':
    /home/kashyapc/tinker-space/libvirt/./src/qemu/qemu_migration.c:1997:17: error: 'format' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             mon_ret = qemuMonitorDriveMirror(priv->mon, diskAlias, nbd_dest,
                     ^
    /home/kashyapc/tinker-space/libvirt/./src/qemu/qemu_migration.c:1971:21: note: 'format' was declared here
             const char *format;



PS: Apologies if this ends up being a double email, the first email was
accidentally sent from my @fedoraproject.org address (which is not
subscribed to this list).


-- 
/kashyap