[libvirt] [PATCH v4 0/6] virsh: Further improve handling of integer options

Andrea Bolognani abologna at redhat.com
Tue Jun 2 09:17:23 UTC 2015


As suggested by Michal: now that we have a generic error message for
failures related to the parsing of integer options, it makes sense to
perform the corresponding check in a single spot instead of replicating
it every time vshCommandOpt*() is used.

Andrea Bolognani (6):
  tests: Add a bunch of new tests to virsh-optparse
  virsh: Use standard error messages in vshCommandOptTimeoutToMs()
  virsh: Improve vshCommandOptTimeoutToMs()
  virsh: Make vshCommandOptScaledInt() use vshCommandOpt()
  virsh: Pass vshControl to all vshCommandOpt*() calls
  virsh: Move error messages inside vshCommandOpt*() functions

 tests/vcpupin                |   4 +-
 tests/virsh-optparse         | 179 ++++++++++++++++++++++++++++++
 tools/virsh-domain-monitor.c |  17 +--
 tools/virsh-domain.c         | 226 ++++++++++++--------------------------
 tools/virsh-host.c           |  67 +++---------
 tools/virsh-interface.c      |   6 +-
 tools/virsh-network.c        |  10 +-
 tools/virsh-nodedev.c        |   4 +-
 tools/virsh-snapshot.c       |   2 +-
 tools/virsh-volume.c         |  26 +----
 tools/virsh.c                | 252 ++++++++++++++++++++++++++-----------------
 tools/virsh.h                |  66 ++++++------
 12 files changed, 461 insertions(+), 398 deletions(-)

-- 
2.1.0




More information about the libvir-list mailing list