[libvirt] [PATCH] virsh: Fix Ctrl-C behavior when watching a job

[Ján Tomko]

On Mon, Jun 01, 2015 at 09:05:59PM +0200, Jiri Denemark wrote:
> When watching a job (save, managedsave, dump, migrate) virsh spawns a
> thread to call the appropriate API and waits for the result while
> watching for interruption signals (SIGINT, Ctrl-C on the terminal).
> Whenever such signal is caught, virsh calls virDomainAbortJob, stops
> waiting for the job, and returns the result of virDomainAbortJob.
> 
> This is wrong because the job might have finished in the meantime or it
> might have been cancelled by someone else and virsh would just report
> the failure to abort the job. However, we are not interested in the
> virDomainAbortJob's result at all, we need to keep waiting for the main
> job to finish and report its result instead.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1131755
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  tools/virsh-domain.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150602/26c4a3a6/attachment-0001.sig>