[libvirt] [PATCH v2] utiltest: Use int8_t instead of char.
Peter Krempa
pkrempa at redhat.com
Mon Jun 8 11:29:14 UTC 2015
On Mon, Jun 08, 2015 at 12:58:06 +0200, Michal Privoznik wrote:
> Not every architecture out there has 'char' signed by default.
> For instance, my arm box has it unsigned by default:
>
> $ gcc -dM -E - < /dev/null | grep __CHAR_UNSIGNED__
> #define __CHAR_UNSIGNED__ 1
>
> Therefore, after 65c61e50 the test if failing for me. Problem is,
> we are trying to assign couple of negative values into char
> assuming some will overflow and some don't. That can't be the
> case if 'char' is unsigned by default. Lets use more explicit types
> instead: int8_t and uint8_t where is no ambiguity.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> tests/utiltest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
ACK,
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150608/308a1e3a/attachment-0001.sig>
More information about the libvir-list
mailing list