[libvirt] [PATCH 0/2] Fix network names with quotes

[Shivaprasad bhat]

On Mon, Jun 8, 2015 at 7:09 PM, Michal Privoznik <mprivozn at redhat.com> wrote:
> On 01.06.2015 10:06, Shivaprasad G Bhat wrote:
>> The following series implements...
>>
>> ---
>>
>> Shivaprasad G Bhat (2):
>>       fix domaincommon.rng to accept network name with quotes
>>       escape quotes for dsmasq conf contents
>>
>>
>>  docs/schemas/domaincommon.rng                      |    2 +-
>>  src/util/virdnsmasq.c                              |   25 +++++++++++++++----
>>  src/util/virpidfile.c                              |   15 ++++++++----
>>  .../nat-network-name-with-quotes.conf              |   20 +++++++++++++++
>>  .../nat-network-name-with-quotes.xml               |   26 ++++++++++++++++++++
>>  tests/networkxml2conftest.c                        |    1 +
>>  6 files changed, 79 insertions(+), 10 deletions(-)
>>  create mode 100644 tests/networkxml2confdata/nat-network-name-with-quotes.conf
>>  create mode 100644 tests/networkxml2confdata/nat-network-name-with-quotes.xml
>>
>
>
> There's nothing wrong with the patches. I'm just curious, what's the use
> case? I always thought that name should be something simple. On the
> other hand, we do something similar with domain names IIRC.
>

Hi Michal,

I too am not sure if the client apps use the quotes. My tester
reported it having issues as he was trying
combinations including non-english language characters.

I saw the quotes being handled diligently everywhere except here. So
posted the patches fixing them.

Thanks,
Shiva



> Michal
>