[libvirt] [PATCH v2 03/22] qemu: Properly report failed migration

Peter Krempa pkrempa at redhat.com
Tue Jun 9 14:27:43 UTC 2015


On Tue, Jun 02, 2015 at 14:34:08 +0200, Jiri Denemark wrote:
> Because we are polling we may detect some errors after we asked QEMU for
> migration status even though they occurred before. If this happens and
> QEMU reports migration completed successfully, we would happily report
> the migration succeeded even though we should have cancelled it because
> of the other error.
> 
> In practise it is not a big issue now but it will become a much bigger
> issue once the check for storage migration status is moved inside the
> loop in qemuMigrationWaitForCompletion.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
> 
> Notes:
>     Version 2:
>     - really do what commit message describes
>     
>     Already ACKed in version 1 :-)

/me will deny everything!

> 
>  src/qemu/qemu_migration.c | 48 +++++++++++++++++++++++------------------------
>  1 file changed, 23 insertions(+), 25 deletions(-)

ACK,

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150609/e46f4ae5/attachment-0001.sig>


More information about the libvir-list mailing list