[libvirt] [PATCH] util: Fix coverity warings in virProcessGetAffinity

[Peter Krempa]

On Wed, Jun 10, 2015 at 15:18:15 -0600, Eric Blake wrote:
> On 06/10/2015 09:27 AM, John Ferlan wrote:
> 
> >> So there are basically three options:
> >> 1) Silence the coverity warning
> > 
> > So on line just prior to CPU_ISSET_S either:
> > 
> > sa_assert(sizeof(unsigned long int) == sizeof(cpu_set_t));
> 
> Is that true even on 32-bit platforms?

This is never true. cpu_set_t is a structure that contains array of
unsigned longs that is 1024bits wide.

> 
> > 
> > or
> > 
> > /* coverity[overrun-local] */
> 
> Might be safer, even though I generally prefer sa_assert() over /* magic
> comment */

I'd go with this one in this case since the sa_assert one above probably
silences the warning in a bogous way.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150611/91987487/attachment-0001.sig>