[libvirt] [PATCH] qemuBuildDriveStr: s/virBufferEscapeString/virBufferAsprintf/

John Ferlan jferlan at redhat.com
Fri Jun 12 13:57:46 UTC 2015



On 06/08/2015 11:03 AM, Michal Privoznik wrote:
> We are using it to print a value that can't be NULL and does not need
> any escaping anyway.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_command.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Comes straight from virDomainDiskGeometryTransTypeToString

ACK

John
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 61faa57..b8cdd3c 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -3724,7 +3724,7 @@ qemuBuildDriveStr(virConnectPtr conn,
>                            disk->geometry.sectors);
>  
>          if (disk->geometry.trans != VIR_DOMAIN_DISK_TRANS_DEFAULT)
> -            virBufferEscapeString(&opt, ",trans=%s", trans);
> +            virBufferAsprintf(&opt, ",trans=%s", trans);
>      }
>  
>      if (disk->serial &&
> 




More information about the libvir-list mailing list