[libvirt] [libvirt-glib] gconfig: Fix small leak in test-domain-create

Daniel P. Berrange berrange at redhat.com
Wed Jun 17 09:40:04 UTC 2015


On Wed, Jun 17, 2015 at 10:49:05AM +0200, Christophe Fergeau wrote:
> Ping?
> 
> On Mon, Apr 13, 2015 at 11:09:31AM +0200, Christophe Fergeau wrote:
> > The object returned by gvir_config_domain_disk_get_driver() must be
> > unref'ed when no longer used.
> > ---
> >  libvirt-gconfig/tests/test-domain-create.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c
> > index eb4b945..417d3d0 100644
> > --- a/libvirt-gconfig/tests/test-domain-create.c
> > +++ b/libvirt-gconfig/tests/test-domain-create.c
> > @@ -284,6 +284,7 @@ int main(int argc, char **argv)
> >      g_assert(gvir_config_domain_disk_driver_get_copy_on_read(driver));
> >      g_assert(gvir_config_domain_disk_get_target_bus(disk) == GVIR_CONFIG_DOMAIN_DISK_BUS_IDE);
> >      g_str_const_check(gvir_config_domain_disk_get_target_dev(disk), "hda");
> > +    g_object_unref(driver);
> >  
> >  
> >      /* network interfaces node */

ACK

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list