[libvirt] [PATCH 1/2] qemu: Jump to correct label in qemuDomainPinIOThread

Peter Krempa pkrempa at redhat.com
Thu Jun 18 13:39:38 UTC 2015


If virDomainObjGetDefs used in qemuDomainPinIOThread would fail the code
would jump to the 'cleanup' label after acquiring the job, thus the VM
would be locked forever.

Introduced in commit cac6d639.
---
 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index eb07b7a..3a70b18 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5790,7 +5790,7 @@ qemuDomainPinIOThread(virDomainPtr dom,
         goto cleanup;

     if (virDomainObjGetDefs(vm, flags, &def, &persistentDef) < 0)
-        goto cleanup;
+        goto endjob;

     if (!(pcpumap = virBitmapNewData(cpumap, maplen)))
         goto endjob;
-- 
2.4.1




More information about the libvir-list mailing list