[libvirt] [PATCH 0/5 v2] Corrections to SCSI logical unit handling

[John Ferlan]

On 06/16/2015 11:29 PM, Eric Farman wrote:
> While working with the hostdev tag and SCSI LUNs, a problem was
> discovered with the XML schema (see commit message in patch 4).
> This spawned some further corrections to the handling of the
> logical unit field throughout libvirt.
> 
> This series was split from a single patch, from this feedback:
> http://www.redhat.com/archives/libvir-list/2015-June/msg00489.html
> 
> Eric Farman (5):
>   Print SCSI logical unit as a positive integer
>   Print SCSI logical unit as unsigned integer
>   Convert SCSI logical unit from int to long long
>   docs: Fix XML schema handling of LUN address in hostdev tag
>   docs: Correct typos in scsi hostdev and address elements
> 
>  docs/formatdomain.html.in     | 10 +++++++---
>  docs/schemas/domaincommon.rng | 14 ++++++++++++--
>  src/conf/domain_audit.c       |  2 +-
>  src/conf/domain_conf.c        |  4 ++--
>  src/conf/domain_conf.h        |  2 +-
>  src/qemu/qemu_command.h       |  2 +-
>  src/qemu/qemu_hotplug.c       |  4 ++--
>  src/util/virhostdev.c         |  6 +++---
>  src/util/virscsi.c            | 16 ++++++++--------
>  src/util/virscsi.h            |  8 ++++----
>  tests/testutilsqemu.c         |  2 +-
>  tools/virsh-domain.c          |  6 +++---
>  12 files changed, 45 insertions(+), 31 deletions(-)
> 


While I understand the comments regarding the step by step process -
consider bisection when/if something went wrong with these patches in
the future...  Was the issue because we parsed a positive integer?  Was
the issue because we printed an unsigned value?  Was the issue because
we printed a long long unsigned? Easier to revert something smaller and
rework, than have to go through everything.

I've made adjustments in my local branch to add the unsigned for bus and
target, as well as a couple of other adjustments I've noted. I'll give
it a day or so to percolate before pushing though just in case I've
missed something...

Tks -

John

John