[libvirt] [libvirt-php][PATCH 0/7] Switch to space indent instead of TABs

[Eric Blake]

On 06/19/2015 03:17 AM, Michal Privoznik wrote:
> Yeah, this is a big change. However, it's needed. Indenting by
> TABs leads to more headache and the sooner we do this the better.
> I've pushed the patches to my github too:
> 
>   https://github.com/zippy2/libvirt-php/commits/fixes
> 
> Maybe we should introduce a syntax-check rule too. BUT - there's
> no gnulib submodule (which introduction would be another
> headache, so I'm okay with leaving that as an exercise for
> somebody else).
> 
> Now, I realize there's not much reviewer's bandwidth, so what if
> I just give you guys some time, and if there's no review in say a
> week or two, I'll go ahead and push this?

For secondary repos, that's probably an acceptable policy to follow (I
for one tend to skip php-related mails, as it is not my strong point).
It's still worth waiting for ACKs on the primary libvirt.git, though :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150619/2ff5c900/attachment-0001.sig>