[libvirt] [PATCH v2] docs: Properly mark acl.html dependencies

Martin Kletzander mkletzan at redhat.com
Wed Jun 24 10:44:37 UTC 2015


On Wed, Jun 24, 2015 at 08:53:21AM +0200, Peter Krempa wrote:
>On Tue, Jun 23, 2015 at 14:46:36 +0200, Martin Kletzander wrote:
>> On Tue, Jun 23, 2015 at 01:56:00PM +0200, Michal Privoznik wrote:
>> >The acl.html file includes aclperms.htmlinc which is generated.
>> >However, acl.html is generated too from acl.html.tmp. And in fact,
>> >this is the place where the aclperms file is needed. Fix the
>> >dependency in Makefile.
>> >
>> >Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> >---
>> >
>>
>> ACK (I thought I ACKed the previous one with this modification, I
>> don't know why :).
>>
>> >diff to v1:
>> >- Fix the origin of the error
>> >
>> > docs/Makefile.am | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> >diff --git a/docs/Makefile.am b/docs/Makefile.am
>> >index b7b49cb..13dddf8 100644
>> >--- a/docs/Makefile.am
>> >+++ b/docs/Makefile.am
>> >@@ -163,7 +163,7 @@ EXTRA_DIST=					\
>> >   sitemap.html.in aclperms.htmlinc \
>> >   todo.pl hvsupport.pl todo.cfg-example
>> >
>> >-acl.html:: $(srcdir)/aclperms.htmlinc
>> >+acl.html.tmp: $(srcdir)/aclperms.htmlinc
>
>Now after a build I get:
>
>$ git status
>On branch master
>Your branch is up-to-date with 'origin/master'.
>Untracked files:
>  (use "git add <file>..." to include in what will be committed)
>
>	docs/acl.html.tmp
>
>nothing added to commit but untracked files present (use "git add" to track)

Aha!  I guess that's why the double colon must be there, because it
sets one dependency and then there are bunch of other rules that I
haven't found the first time (using wildcards), like '%.html: %.html.tmp'

Weird that I don't see that after build...

>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150624/edd9e650/attachment-0001.sig>


More information about the libvir-list mailing list