[libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox

[Daniel P. Berrange]

On Thu, Jun 25, 2015 at 01:27:20PM +0200, Eren Yagdiran wrote:
> Hello,
> 
> These patches provide disk support for libvirt-sandbox.
> Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox.
> 
> --Main diffs compared to previous patches.
> 
> Since many hypervisors, including kvm, will not even honour requested
> names for disk devices we link each device under /dev/disk/by-tag
> 
> e.g /dev/disk/by-tag/foobar -> /dev/sda

Right, but several patches in this series still deal with allowing
the user to specify the /dev/sda name it appears.

> 
> We populate disks.cfg with tag to device mapping when we build the sandbox.
> After that, in each init-process {Common,Qemu}, we basically read the configuration
> and populate the right symlinks under /dev/disk/by-tag
> 
> The common functions for modifying directories are moved under Init-util.
> {Common,Qemu} inits are using them.

On a general point, can you make sure to run

 'make syntax-check'

on every patch - there are style mistakes on many of these patches that
would break the syntax check

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|