[libvirt] [PATCH] conf: fix not format priority when it is zero

Martin Kletzander mkletzan at redhat.com
Thu Jun 25 21:26:22 UTC 2015


On Wed, Jun 24, 2015 at 12:00:36PM +0800, Luyao Huang wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1235116
>
>We do not format the priority if it is 0, but this will
>be a broken settings in guest. Change the condition of
>format priority element to always format priority if
>scheduler is 'fifo' or 'rr'.
>
>Signed-off-by: Luyao Huang <lhuang at redhat.com>
>---
>I haven't intorduce a new bool parameter to mark if we
>set the priority value just like the other place we avoid
>this issue, because i think this looks unnecessary in this
>place.
>
> src/conf/domain_conf.c                             |  6 ++--

The part for domain_conf.c didn't apply properly, but it's easy enough
to fix.

I modified the commit message as follows and pushed the patch:

    conf: Format scheduler priority when it is zero

    According to our XML definition, zero is as valid as any other value.
    Mainly because it should be kernel-agnostic.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150625/fe2a5c0e/attachment-0001.sig>


More information about the libvir-list mailing list