[libvirt] [sandbox PATCH 03/10] Add disk parameter to virt-sandbox

[Daniel P. Berrange]

On Fri, Jun 26, 2015 at 03:27:38PM +0200, Eren Yagdiran wrote:
> Allow users to add disk images to their sandbox. Only disk images are supported so far, but the
> parameter is intentionally designed for future changes.
> ---
>  bin/virt-sandbox.c | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c
> index 1ab2f8a..3373c7f 100644
> --- a/bin/virt-sandbox.c
> +++ b/bin/virt-sandbox.c
> @@ -63,6 +63,7 @@ int main(int argc, char **argv) {
>      GMainLoop *loop = NULL;
>      GError *error = NULL;
>      gchar *name = NULL;
> +    gchar **disks = NULL;
>      gchar **mounts = NULL;
>      gchar **includes = NULL;
>      gchar *includefile = NULL;
> @@ -92,6 +93,8 @@ int main(int argc, char **argv) {
>            N_("name of the sandbox"), "NAME" },
>          { "root", 'r', 0, G_OPTION_ARG_STRING, &root,
>            N_("root directory of the sandbox"), "DIR" },
> +        { "disk", ' ', 0, G_OPTION_ARG_STRING_ARRAY, &disks,
> +          N_("add a disk in the guest"), "TYPE:TAGNAME=SOURCE,FORMAT=FORMAT" },

FORMAT=FORMAT shoud be format=FORMAT


> +=item B<--disk TYPE:TAGNAME=SOURCE,FORMAT=FORMAT>
> +
> +Sets up a disk inside the sandbox by using B<SOURCE> with a symlink named as B<TAGNAME>
> +and type B<TYPE> and format B<FORMAT>. Example: file:hda=/var/lib/sandbox/demo/tmp.qcow2,format=qcow2

'hda' should be an example tag name

ACK, I'll make the changes needed

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|